Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: logging test may fail if some config fails #1695

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

cheng-tan
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b270a2e) 39.41% compared to head (527ec5b) 39.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   39.41%   39.41%           
=======================================
  Files          56       56           
  Lines        5990     5990           
  Branches     1334     1334           
=======================================
  Hits         2361     2361           
  Misses       3436     3436           
  Partials      193      193           
Flag Coverage Δ
unittests 39.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 15, 2024
Merged via the queue into microsoft:main with commit 5ca69da Feb 15, 2024
19 of 23 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants