Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow limiting the maximum number of turns in initiate_chat and initiate_chats #1703

Merged
merged 7 commits into from
Feb 17, 2024

Conversation

qingyun-wu
Copy link
Contributor

Why are these changes needed?

This PR adds an argument in initiate_chat to allow users to limit the maximum number of conversation turns

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bf3cc0f) 39.62% compared to head (9fbfacb) 58.42%.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 84.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1703       +/-   ##
===========================================
+ Coverage   39.62%   58.42%   +18.79%     
===========================================
  Files          57       57               
  Lines        6006     6020       +14     
  Branches     1338     1464      +126     
===========================================
+ Hits         2380     3517     +1137     
+ Misses       3433     2222     -1211     
- Partials      193      281       +88     
Flag Coverage Δ
unittests 58.40% <85.71%> (+18.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 17, 2024
Merged via the queue into main with commit a00df55 Feb 17, 2024
53 of 60 checks passed
@sonichi sonichi deleted the turn-number branch February 17, 2024 18:16
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…itiate_chats` (microsoft#1703)

* max_turns

* add notebook

* simplify code

* groupchat _prepare_chat

* doc

* add doc

* Update autogen/agentchat/conversable_agent.py

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants