Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoBuild] fix test error #1750

Merged
merged 103 commits into from
Feb 21, 2024
Merged

[AutoBuild] fix test error #1750

merged 103 commits into from
Feb 21, 2024

Conversation

LinxinS97
Copy link
Collaborator

Why are these changes needed?

Fix AutoBuild test error by removing the TERMINATE assertion.

Related issue number

Checks

LinxinS97 and others added 30 commits December 4, 2023 10:33
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
# Conflicts:
#	autogen/agentchat/contrib/agent_builder.py
# Conflicts:
#	autogen/agentchat/contrib/agent_builder.py
# Conflicts:
#	autogen/agentchat/contrib/agent_builder.py
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a34e4cc) 39.35% compared to head (0dcca8c) 21.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1750       +/-   ##
===========================================
- Coverage   39.35%   21.28%   -18.07%     
===========================================
  Files          57       57               
  Lines        6093     6093               
  Branches     1362     1481      +119     
===========================================
- Hits         2398     1297     -1101     
- Misses       3499     4643     +1144     
+ Partials      196      153       -43     
Flag Coverage Δ
unittests 21.28% <ø> (-18.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. "TERMINATE" not required in sys message now?

@qingyun-wu qingyun-wu added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 07520aa Feb 21, 2024
55 of 60 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* try to fix blog

* modify blog

* fix test error in microsoft#717; fix blog typo in installation; update blogs with output examples.

* pre-commit

* pre-commit

* Update website/blog/2023-11-26-Agent-AutoBuild/index.mdx

Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>

* add future work

* fix grammar

* update agent_builder

* solve microsoft#941; add detailed debug info; support json string config

* pre-commit

* solve microsoft#954

* pre-commit

* [new feature] build group chat agents from library.

* pre-commit

* add authors' info in notebook; add a new notebook for build_from_library; reduce prompt effort

* update test and example for build_from_library

* pre-commit

* add notebook; update docs

* change notebook name

* change description for notebook and doc

* remove default value for default_llm_config

* add embedding similarity agent selection

* pre-commit

* update test

* add dependency installation in github workflow

* update test

* pre-commit

* update notebook

* support directly json as library; support customize embedding model

* update test

* pre-commit

* update github test workflow

* Update autobuild_agent_library.ipynb

* add agent description

* refine prompt; update notebook

* pre-commit

* update test example

* update test

* update test

* update test

* change `config_path` to `config_path_or_env`; update test

* pre-commit

* update test

* update test

* update test: add config_file_location

* change `config_path_or_env` to `config_file_or_env`

* update test

* solve noqa

* fix import error for conftest

* fix test error

* pre-commit

* * update error message in `_create_agent`.
* replace `gpt-4-1106-preview` to `gpt-4` in test file.

* add comment on local server creation; modify notebook; update contrib-openai.yml for test; add autobuild option in setup.py; add autotest model name statement

* move import huggingface_hub to _create_agent

* pre-commit

* add uncover comment in the endpoint creation code block

* recover contrib-openai.yml for merge

* remove TERMINATE assertion for sys msg

* remove TERMINATE assertion

---------

Co-authored-by: Jieyu Zhang <jieyuz2@cs.washington.edu>
Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
@jackgerrits jackgerrits deleted the autobuild branch September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants