Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding register_nested_chats to make nested chat easier #1753

Merged
merged 73 commits into from
Feb 27, 2024
Merged

Adding register_nested_chats to make nested chat easier #1753

merged 73 commits into from
Feb 27, 2024

Conversation

qingyun-wu
Copy link
Contributor

@qingyun-wu qingyun-wu commented Feb 21, 2024 •
edited
Loading

Why are these changes needed?

Adding register_nested_chats to make nested chat easier.
The API is subject to change. Comments are appreciated.

TODO

  • Add the notebooks to the example pages
  • Improve docstr and documentation

Related issue number

Checks

qingyun-wu and others added 30 commits February 7, 2024 13:36
@qingyun-wu
add util
a13fba7
@qingyun-wu
add notebook
8fb3dd7
@qingyun-wu
SoM notebook
cd7349f
@qingyun-wu
doc
3d63f94
@qingyun-wu
update notebook
b8f00cc
@qingyun-wu
SoM
cb2924e
@qingyun-wu
optiguide
ee1b7b5
@qingyun-wu
rename
40ee04f
@qingyun-wu
add implementation
4e3c7d0
@qingyun-wu
Merge remote-tracking branch 'origin/main' into nestchat
24e2cd1
@qingyun-wu
update notebook
e61a141
@qingyun-wu
update notebook
92153ae
@qingyun-wu
update notebook
4ab3d64
@qingyun-wu
summary method
14ca65f
@qingyun-wu
Merge remote-tracking branch 'origin/main' into nestchat
33a3439
@qingyun-wu
initiate_chats enhancements
64acda0
@qingyun-wu
callable summary_method
d87921a
@qingyun-wu
summary method
f66df38
@qingyun-wu
summary method default
69fa176
@qingyun-wu
Merge branch 'main' into summary
cac26bf
@qingyun-wu
docstr
a6a1faa
@ekzhu
add timeout to slient pip install test
7125c90
@qingyun-wu
consolidate_chat_info
c48e26c
@qingyun-wu
Merge branch 'summary' of github.com:microsoft/autogen into summary
4a65cef
@qingyun-wu
a_initiate_chat
48db528
@qingyun-wu
Merge branch 'summary' into nestchat
f117d2d
@qingyun-wu
AssertionError tests
f6bcb9f
@qingyun-wu
AssertionError test
d9739e9
@qingyun-wu
update tests
dfaa118
@qingyun-wu
Merge branch 'summary' into nestchat
34672a8
BeibinLi
BeibinLi approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The readability improves a lot.

LGTM.

@qingyun-wu qingyun-wu added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 27, 2024
@qingyun-wu qingyun-wu added this pull request to the merge queue Feb 27, 2024
@qingyun-wu qingyun-wu removed this pull request from the merge queue due to a manual request Feb 27, 2024
@qingyun-wu qingyun-wu added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 27, 2024
@qingyun-wu qingyun-wu added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit c6f6707 Feb 27, 2024
60 checks passed
@qingyun-wu qingyun-wu mentioned this pull request Mar 14, 2024
Open
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@qingyun-wu @ekzhu
@signalprime @gagb
Adding register_nested_chats to make nested chat easier (microsoft#…
1eaf77a 
…1753)

* add util

* add notebook

* SoM notebook

* doc

* update notebook

* SoM

* optiguide

* rename

* add implementation

* update notebook

* update notebook

* update notebook

* summary method

* initiate_chats enhancements

* callable summary_method

* summary method

* summary method default

* docstr

* add timeout to slient pip install test

* consolidate_chat_info

* a_initiate_chat

* AssertionError tests

* AssertionError test

* update tests

* update test

* remove redudant file

* kwargs

* update notebook

* update notebook

* nested

* update SoM

* update notebook

* max_turns

* add notebook

* updatenotebook

* add notebooks

* update notebook and test

* add links to the example page

* annotations

* documentation

* default values

* Expanded details about the purpose of each cell

* update default value

* default value for reply_func_from_nested_chats

* default reply func name

* update notebook

* update optiGuide

* upload fig

* optiGuide notebook

* doc

* update notebook

* update notebook

* notebook format

* update optiguide notebook

* raise value error

* update notebook

* Improve language

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: signalprime <15487280+signalprime@users.noreply.github.com>
Co-authored-by: gagb <gagb@users.noreply.github.com>
@jackgerrits jackgerrits deleted the nestedchat-dev branch September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekzhu ekzhu ekzhu left review comments

@signalprime signalprime signalprime left review comments

@BeibinLi BeibinLi BeibinLi approved these changes

@afourney afourney Awaiting requested review from afourney

@victordibia victordibia Awaiting requested review from victordibia

@jackgerrits jackgerrits Awaiting requested review from jackgerrits

@sonichi sonichi Awaiting requested review from sonichi

@skzhang1 skzhang1 Awaiting requested review from skzhang1

@gagb gagb Awaiting requested review from gagb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qingyun-wu @codecov-commenter @sonichi @ekzhu @BeibinLi @gagb @signalprime