Updating code_utils.py to solve issue #1747 #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the powershell command to pwsh
added a split to handle powershell in the first condition as well
added "pwsh" as a command option in lang variable
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
fixed formatting
defined a function to detect whether 'powershell' or 'pwsh' works and accordingly use the one that works
fixed formatting
added a unit test for get_powershell_command function in code_utils.py
fixed formatting
fixed formatting
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
BeibinLi
reviewed
Feb 22, 2024
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
abhaymathur21
had a problem deploying
to
openai1
GitHub Actions
Failure
3 tasks
BeibinLi
approved these changes
Feb 23, 2024
No problem! How do I merge this PR now? It still says merging is blocked |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Update code_utils.py Updated the powershell command to pwsh * Update code_utils.py added a split to handle powershell in the first condition as well * Update local_commandline_code_executor.py added "pwsh" as a command option in lang variable * Update autogen/coding/local_commandline_code_executor.py Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com> * Update code_utils.py * Update code_utils.py fixed formatting * Update code_utils.py defined a function to detect whether 'powershell' or 'pwsh' works and accordingly use the one that works * Update code_utils.py fixed formatting * Update and rename test_code.py to test_code_utils.py added a unit test for get_powershell_command function in code_utils.py * Update test_code_utils.py fixed formatting * Update test_code_utils.py fixed formatting * Update autogen/code_utils.py Co-authored-by: Chi Wang <wang.chi@microsoft.com> * solved issue microsoft#1747 * updated unit test * fixed formatting * fixed formatting * fixed formatting * fixed a bug * removed extra return None and removed redundant comments --------- Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com> Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These changes are needed since the print statement print("Neither powershell nor pwsh is installed.") was being noisy and unnecessarily repetitive. It was giving this warning for linux systems as well thinking that there is something wrong with the system because neither powershell nor pwsh is installed but linux systems dont have either anyway so this warning is unnecessary for non-windows operating systems.
I added a condition so that the warning only gets issued if the OS is detected as windows since if it is any other OS, powershell or pwsh need not be there, some other terminal may be used like bash for linux for example.
I also replace print with logging.warning so that the warning isnt given repetitively
Related issue number
Closes #1747
Checks