Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make default model of a constant class variable #1780

Merged
merged 4 commits into from
Feb 28, 2024
Merged

make default model of a constant class variable #1780

merged 4 commits into from
Feb 28, 2024

Conversation

RohitRathore1
Copy link
Contributor

@RohitRathore1 RohitRathore1 commented Feb 24, 2024 •
edited
Loading

Why are these changes needed?

It involves interactions with OpenAI's API, managing configurations, and handling assistant threads and messages, incorporating a class-level constant for the default model name improves maintainability and clarity of the code. This change allows for a centralized point of reference for the default model, making updates or modifications simpler and more straightforward.

Related issue number

Closes #1777

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.08%. Comparing base (b872789) to head (fcdac9d).
Report is 631 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1780       +/-   ##
===========================================
+ Coverage   36.96%   61.08%   +24.11%     
===========================================
  Files          62       62               
  Lines        6528     6529        +1     
  Branches     1447     1571      +124     
===========================================
+ Hits         2413     3988     +1575     
+ Misses       3921     2185     -1736     
- Partials      194      356      +162
Flag Coverage Δ
unittests 60.88% <100.00%> (+23.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RohitRathore1 RohitRathore1 marked this pull request as draft February 24, 2024 09:44
@RohitRathore1 RohitRathore1 marked this pull request as ready for review February 26, 2024 04:52
IANTHEREAL
IANTHEREAL approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and please address gagb's comment

@sonichi sonichi added this pull request to the merge queue Feb 28, 2024
Merged via the queue into microsoft:main with commit d35754d Feb 28, 2024
53 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@RohitRathore1 @sonichi
make default model of a constant class variable (microsoft#1780)
6354fb7 
* make default model of  a constant class variable

* make default model of  a constant class variable

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagb gagb gagb left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

@jtrugman jtrugman Awaiting requested review from jtrugman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make default model of GPTAssistantAgent a constant class variable.
5 participants
@RohitRathore1 @codecov-commenter @IANTHEREAL @gagb @sonichi