Allow user to pass in a customized speaker selection method #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
===========================================
+ Coverage 36.10% 59.67% +23.56%
===========================================
Files 63 63
Lines 6658 6670 +12
Branches 1470 1600 +130
===========================================
+ Hits 2404 3980 +1576
+ Misses 4056 2330 -1726
- Partials 198 360 +162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
reviewed
Feb 26, 2024
qingyun-wu
reviewed
Feb 29, 2024
|
@kevin666aa is this ready for review? It is currently a draft PR. Please make a PR once it is ready. Thanks! |
qingyun-wu
reviewed
Mar 5, 2024
|
Could you add the link to the newly added example in the Example page on website: https://microsoft.github.io/autogen/docs/Examples? Thanks! |
qingyun-wu
approved these changes
Mar 7, 2024
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…t#1791) * init PR * update * update code check * update * update * update * update * Test the ability to have agents a,u,t,o,g,e,n speak in turn. * update * update * update * Evidence that groupchat not terminating because of the TERMINATE substring. * Raising NoEligibleSpeakerException allows graceful exit before max turns * update * To confirm with author that custom function is meant to override graph constraints * Confirmed the expected test behaviour with author * Update autogen/agentchat/groupchat.py * update * update --------- Co-authored-by: Joshua Kim <Joshua@spectdata.com> Co-authored-by: Qingyun Wu <qingyun0327@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to pass in a
customized_speaker_selection_func(last_speaker: Agent, messages: List[Dict])to determine what should be the next agent.If the function returns None, the default speaker_selection_method is used.
Why are these changes needed?
Related issue number
Potentially closes #778
Checks