Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement docker based jupyter executor #1794

Merged
merged 12 commits into from
Feb 29, 2024

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Feb 26, 2024

Why are these changes needed?

Implements a Docker based jupyter code execution environment.

Example:

with DockerJupyterServer() as jupyter_server:
    agent = ConversableAgent(
        "user_proxy",
        llm_config=False,
        code_execution_config={"executor": JupyterCodeExecutor(jupyter_server=jupyter_server)},
    )

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 1.66667% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 54.56%. Comparing base (5b0c919) to head (f50e819).
Report is 1 commits behind head on main.

Files Patch % Lines
autogen/coding/jupyter/docker_jupyter_server.py 0.00% 81 Missing ⚠️
autogen/coding/jupyter/jupyter_code_executor.py 0.00% 17 Missing ⚠️
autogen/coding/jupyter/jupyter_client.py 7.69% 12 Missing ⚠️
autogen/coding/jupyter/__init__.py 0.00% 4 Missing ⚠️
...n/coding/jupyter/embedded_ipython_code_executor.py 0.00% 3 Missing ⚠️
autogen/coding/factory.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1794       +/-   ##
===========================================
+ Coverage   36.95%   54.56%   +17.60%     
===========================================
  Files          62       63        +1     
  Lines        6529     6625       +96     
  Branches     1447     1579      +132     
===========================================
+ Hits         2413     3615     +1202     
+ Misses       3922     2712     -1210     
- Partials      194      298      +104     
Flag Coverage Δ
unittests 54.53% <1.66%> (+17.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 29, 2024
Merged via the queue into microsoft:main with commit 76ef078 Feb 29, 2024
50 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Implement docker based jupyter client

* formatting

* skip docker tests when asked

* feedback

* add log

* update build

* formatting

* structural changes

* update setup.py

* update tests

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants