Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a configurable constant #1819

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Conversation

RohitRathore1
Copy link
Contributor

Why are these changes needed?

This modification ensure that the introduction message is easily configurable and can be changed without altering the method's logic directly.

Related issue number

Closes #1690

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (b8ceb86) to head (d18bb6a).
Report is 42 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1819       +/-   ##
===========================================
+ Coverage   36.95%   47.65%   +10.69%     
===========================================
  Files          62       64        +2     
  Lines        6529     6837      +308     
  Branches     1447     1629      +182     
===========================================
+ Hits         2413     3258      +845     
+ Misses       3922     3310      -612     
- Partials      194      269       +75     
Flag Coverage Δ
unittests 47.52% <100.00%> (+10.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JieyuZ2
Copy link
Collaborator

JieyuZ2 commented Feb 29, 2024

would it be better to make the intro msg an argument instead of configurable constant?

@RohitRathore1
Copy link
Contributor Author

would it be better to make the intro msg an argument instead of configurable constant?

It would be a better option but as per issue I had opened my PR. @sonichi what do you think about the suggestion from @JieyuZ2? And other changes look good to me.

Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
@sonichi sonichi added the group chat/teams group-chat-related issues label Mar 10, 2024
@sonichi
Copy link
Contributor

sonichi commented Mar 10, 2024

would it be better to make the intro msg an argument instead of configurable constant?

It would be a better option but as per issue I had opened my PR. @sonichi what do you think about the suggestion from @JieyuZ2? And other changes look good to me.

@JieyuZ2 's suggestion can be addressed in a future PR if there are such needs.

@sonichi sonichi added this pull request to the merge queue Mar 10, 2024
Merged via the queue into microsoft:main with commit b0a8e6e Mar 10, 2024
46 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Made a configurable constant

* Fix typo

Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>

---------

Co-authored-by: Joshua Kim <joshkyh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group chat/teams group-chat-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make init intro msg a configurable constant
5 participants