Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Quarto and use notebook metadata for frontmatter #1836

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Mar 1, 2024

Why are these changes needed?

Related issue number

Checks

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 1, 2024

Once this is merged can you send an update to the #documentation discord channel to announce the usage? and document-contributor role.

@jackgerrits
Copy link
Member Author

Certainly

notebook/contributing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing some typos. I also have confusion about the referred yaml in the sentence "Ensure the first cell is markdown and before absolutely anything else include the following yaml within a comment." Otherwise, look good!

notebook/agentchat_groupchat_finite_state_machine.ipynb Outdated Show resolved Hide resolved
notebook/agentchat_groupchat_finite_state_machine.ipynb Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.69%. Comparing base (97923ee) to head (c0a8251).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1836   +/-   ##
=======================================
  Coverage   35.69%   35.69%           
=======================================
  Files          63       63           
  Lines        6625     6625           
  Branches     1454     1454           
=======================================
  Hits         2365     2365           
  Misses       4067     4067           
  Partials      193      193           
Flag Coverage Δ
unittests 35.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qingyun-wu qingyun-wu added this pull request to the merge queue Mar 2, 2024
Merged via the queue into microsoft:main with commit d604643 Mar 2, 2024
19 of 23 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
)

* Update process_notebook to use metadata instead of a yaml comment

* upgrade quarto and version check in tool

* formatting

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants