Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc about effects for capabilities #1842

Merged
merged 10 commits into from
Mar 3, 2024
Merged

add doc about effects for capabilities #1842

merged 10 commits into from
Mar 3, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Mar 3, 2024

Why are these changes needed?

  • Explain the effect of a capability in docstr.
  • Move tests about capabilities.
  • Use correct path for import.
  • Use pull_request as the trigger of workflow.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.69%. Comparing base (f749dee) to head (dd8079b).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1842       +/-   ##
===========================================
+ Coverage   35.90%   54.69%   +18.78%     
===========================================
  Files          63       63               
  Lines        6637     6608       -29     
  Branches     1456     1581      +125     
===========================================
+ Hits         2383     3614     +1231     
+ Misses       4063     2696     -1367     
- Partials      191      298      +107     
Flag Coverage Δ
unittests 54.66% <100.00%> (+18.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi
Copy link
Contributor Author

sonichi commented Mar 3, 2024

@LittleLittleCloud I changed the trigger back to pull_request to address a security requirement.

@LittleLittleCloud
Copy link
Collaborator

@sonichi

OK sounds good, that might prevent PR from forked repo to consume openai secrets?

@sonichi
Copy link
Contributor Author

sonichi commented Mar 3, 2024

@sonichi

OK sounds good, that might prevent PR from forked repo to consume openai secrets?

Yes. So if a PR requires an openai test, it needs to be made from a branch within this repo.

@sonichi sonichi added this pull request to the merge queue Mar 3, 2024
Merged via the queue into main with commit cd3b5c6 Mar 3, 2024
53 of 71 checks passed
@rickyloynd-microsoft rickyloynd-microsoft mentioned this pull request Mar 7, 2024
3 tasks
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* add doc about effects for capabilities

* remove unnecessary imports

* improve doc

* test

* test location

* polish

* improve import of colored

* termcolor

* termcolor

* use pull request for openai test
@jackgerrits jackgerrits deleted the effect branch September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants