Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise errors if incompatible args are used with an executor #1855

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

If a user tries to use the old/existing way of configuring code execution with an executor it will not work. This raises an error to ensure the user knows it wont work.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 46.79%. Comparing base (799a24e) to head (58311aa).

Files Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1855       +/-   ##
===========================================
+ Coverage   36.03%   46.79%   +10.76%     
===========================================
  Files          63       63               
  Lines        6608     6614        +6     
  Branches     1456     1584      +128     
===========================================
+ Hits         2381     3095      +714     
+ Misses       4036     3269      -767     
- Partials      191      250       +59     
Flag Coverage Δ
unittests 46.71% <0.00%> (+10.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Mar 4, 2024
Merged via the queue into microsoft:main with commit b604c44 Mar 4, 2024
46 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…t#1855)

* Raise errors if incompatible args are used with an executor

* spelling error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants