Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve warning on port binding #1870

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Instead of getting a free port using binding instead relies on the functionality of jupyter kernelgateway

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 46.81%. Comparing base (a54b733) to head (29e0a02).

Files Patch % Lines
autogen/coding/jupyter/local_jupyter_server.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1870       +/-   ##
===========================================
+ Coverage   36.03%   46.81%   +10.78%     
===========================================
  Files          63       63               
  Lines        6618     6619        +1     
  Branches     1459     1585      +126     
===========================================
+ Hits         2385     3099      +714     
+ Misses       4039     3270      -769     
- Partials      194      250       +56     
Flag Coverage Δ
unittests 46.74% <0.00%> (+10.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 5, 2024

Confirmed it works on windows

@sonichi sonichi added this pull request to the merge queue Mar 5, 2024
Merged via the queue into microsoft:main with commit 434b75e Mar 5, 2024
46 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants