Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve type issues in redis cache #1872

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Related issue number

Checks

@ekzhu ekzhu requested a review from vijaykramesh March 6, 2024 07:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 46.82%. Comparing base (09a4918) to head (c2c944b).

Files Patch % Lines
autogen/cache/redis_cache.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1872       +/-   ##
===========================================
+ Coverage   36.02%   46.82%   +10.80%     
===========================================
  Files          63       63               
  Lines        6621     6627        +6     
  Branches     1462     1588      +126     
===========================================
+ Hits         2385     3103      +718     
+ Misses       4041     3272      -769     
- Partials      195      252       +57     
Flag Coverage Δ
unittests 46.74% <84.61%> (+10.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingyun-wu qingyun-wu self-requested a review March 6, 2024 15:43
@qingyun-wu qingyun-wu added this pull request to the merge queue Mar 6, 2024
Merged via the queue into microsoft:main with commit 76a34e2 Mar 6, 2024
46 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants