Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threading issue for logging #1901

Merged
merged 13 commits into from
Mar 8, 2024
Merged

Conversation

cheng-tan
Copy link
Contributor

@cheng-tan cheng-tan commented Mar 7, 2024

Why are these changes needed?

  • Fix mypy errors for logging feature
  • Fix threading error for logging feature

Related issue number

closes #1822

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 68.81720% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 47.62%. Comparing base (2a62ffc) to head (58b7b53).

Files Patch % Lines
autogen/runtime_logging.py 43.33% 12 Missing and 5 partials ⚠️
autogen/logger/sqlite_logger.py 77.77% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1901       +/-   ##
===========================================
+ Coverage   37.21%   47.62%   +10.41%     
===========================================
  Files          64       64               
  Lines        6815     6834       +19     
  Branches     1496     1629      +133     
===========================================
+ Hits         2536     3255      +719     
+ Misses       4067     3310      -757     
- Partials      212      269       +57     
Flag Coverage Δ
unittests 47.49% <68.81%> (+10.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheng-tan cheng-tan changed the title Fix mypy error for logging Fix threading issue for logging Mar 7, 2024
@cheng-tan cheng-tan requested a review from monteduro March 7, 2024 21:29
@sonichi sonichi added this pull request to the merge queue Mar 8, 2024
Merged via the queue into microsoft:main with commit 811fd69 Mar 8, 2024
46 of 57 checks passed
@cheng-tan cheng-tan deleted the logging_type_fix branch March 8, 2024 14:29
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix mypy errors for logging

* cleanup

* formatting

* fix threading issue in logging

* remove kwarg

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants