Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printout check for num code blocks #1902

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Related issue number

Accidentally had the if statement the wrong way around

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.83%. Comparing base (2503000) to head (e954aec).

Files Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1902       +/-   ##
===========================================
+ Coverage   36.13%   46.83%   +10.70%     
===========================================
  Files          63       63               
  Lines        6670     6670               
  Branches     1475     1600      +125     
===========================================
+ Hits         2410     3124      +714     
+ Misses       4060     3290      -770     
- Partials      200      256       +56     
Flag Coverage Δ
unittests 46.76% <0.00%> (+10.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingyun-wu qingyun-wu added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 23e4938 Mar 7, 2024
49 of 60 checks passed
@jackgerrits jackgerrits deleted the jackgerrits-patch-2 branch March 25, 2024 16:00
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants