Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept path for work_dir in LocalCommandLineCodeExecutor #1909

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Aligns the interface with other executors in that it can accept a path.

Related issue number

Checks

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.67%. Comparing base (e9219fe) to head (b7b4d4b).

Files Patch % Lines
autogen/coding/local_commandline_code_executor.py 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1909       +/-   ##
===========================================
+ Coverage   37.09%   47.67%   +10.58%     
===========================================
  Files          64       64               
  Lines        6786     6794        +8     
  Branches     1491     1620      +129     
===========================================
+ Hits         2517     3239      +722     
+ Misses       4061     3291      -770     
- Partials      208      264       +56     
Flag Coverage Δ
unittests 47.58% <91.66%> (+10.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Mar 7, 2024
Merged via the queue into microsoft:main with commit f4f9e6c Mar 7, 2024
46 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
)

* Accept path in LocalCommandLineCodeExecutor

* formatting

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants