Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update whisper notebook to use new function registration syntax #1918

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Closes #1916

Related issue number

Checks

@jackgerrits jackgerrits changed the title Update notebook to use new function registration syntax Update whisper notebook to use new function registration syntax Mar 8, 2024
@sonichi sonichi requested a review from qingyun-wu March 9, 2024 21:22
@sonichi
Copy link
Contributor

sonichi commented Mar 9, 2024

@qingyun-wu could you request review from the original contributor?

@sonichi sonichi requested review from ekzhu and davorrunje March 9, 2024 21:24
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the notebook, it works. One thing: set code_execution_config={} for the user proxy agent to avoid warning.

@jackgerrits
Copy link
Member Author

Updated

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.33%. Comparing base (c5e7665) to head (b1f1fdd).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1918      +/-   ##
==========================================
+ Coverage   37.13%   37.33%   +0.19%     
==========================================
  Files          64       64              
  Lines        6794     6913     +119     
  Branches     1493     1519      +26     
==========================================
+ Hits         2523     2581      +58     
- Misses       4062     4109      +47     
- Partials      209      223      +14     
Flag Coverage Δ
unittests 37.33% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Mar 11, 2024
Merged via the queue into microsoft:main with commit 9684833 Mar 11, 2024
20 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…osoft#1918)

* Update notebook to use new function registration syntax

* Update agentchat_video_transcript_translate_with_whisper.ipynb

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Whisper AI is not working
5 participants