improve validation of llm_config #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonichi
requested review from
AaronWard,
davorrunje,
ekzhu,
jackgerrits and
olgavrou
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
===========================================
+ Coverage 37.33% 60.24% +22.91%
===========================================
Files 64 64
Lines 6913 6913
Branches 1519 1649 +130
===========================================
+ Hits 2581 4165 +1584
+ Misses 4109 2369 -1740
- Partials 223 379 +156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@doganaktar could you test whether this PR solves your issue? |
sonichi
added
llm
models
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* improve validation of llm_config * fixed test_register_for_llm_without_LLM * docstr about llm_config=None * Make None a sentinel * pop tools --------- Co-authored-by: Davor Runje <davor@airt.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current llm_config validation is too restricted and excludes valid configs like #1863
Related issue number
close #1863
Checks