Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local cli executor to use same filename strategy as docker #1981

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Mar 12, 2024

Replaces #1954

Why are these changes needed?

Related issue number

Checks

@jackgerrits
Copy link
Member Author

@sonichi can you run oai tests?

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 47.98%. Comparing base (99df2c5) to head (d2b65c5).
Report is 1 commits behind head on main.

Files Patch % Lines
autogen/coding/local_commandline_code_executor.py 85.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1981       +/-   ##
===========================================
+ Coverage   37.38%   47.98%   +10.59%     
===========================================
  Files          64       65        +1     
  Lines        6879     6910       +31     
  Branches     1518     1647      +129     
===========================================
+ Hits         2572     3316      +744     
+ Misses       4085     3317      -768     
- Partials      222      277       +55     
Flag Coverage Δ
unittests 47.85% <90.62%> (+10.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit d583c80 Mar 12, 2024
112 of 130 checks passed
@sonichi sonichi deleted the consistent_filenames_between_cli branch March 12, 2024 22:23
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…crosoft#1981)

* consistent file saving across cli executors

* test fixes

* feedback

* make path

* formatting

* run timeout test on windows

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants