-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RAG under topics #1990
add RAG under topics #1990
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
==========================================
- Coverage 37.55% 37.53% -0.02%
==========================================
Files 65 65
Lines 6910 6913 +3
Branches 1520 1521 +1
==========================================
Hits 2595 2595
- Misses 4090 4092 +2
- Partials 225 226 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a few changes. LGTM now.
Looks like agentchat_qdrant_RetrieveChat.ipynb and agentchat_oai_assistant_retrieval.ipynb need to be updated so that they could be shown in the notebook section in the website. This can be done in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to change the tone because we'll revamp RAG. We don't want users to take too much dependency on the current solution, right?
* add RAG * demo * correct notebook * Update quarto installation * Update gitignore * Update format * RAG doc --------- Co-authored-by: Li Jiang <bnujli@gmail.com>
Why are these changes needed?
add RAG under topics
Related issue number
Checks