Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RAG under topics #1990

Merged
merged 8 commits into from
Mar 14, 2024
Merged

add RAG under topics #1990

merged 8 commits into from
Mar 14, 2024

Conversation

qingyun-wu
Copy link
Contributor

Why are these changes needed?

add RAG under topics

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.53%. Comparing base (8f6590e) to head (cfd3563).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
- Coverage   37.55%   37.53%   -0.02%     
==========================================
  Files          65       65              
  Lines        6910     6913       +3     
  Branches     1520     1521       +1     
==========================================
  Hits         2595     2595              
- Misses       4090     4092       +2     
- Partials      225      226       +1     
Flag Coverage Δ
unittests 37.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a few changes. LGTM now.

Looks like agentchat_qdrant_RetrieveChat.ipynb and agentchat_oai_assistant_retrieval.ipynb need to be updated so that they could be shown in the notebook section in the website. This can be done in a separate PR.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to change the tone because we'll revamp RAG. We don't want users to take too much dependency on the current solution, right?

.gitignore Outdated Show resolved Hide resolved
website/docs/topics/retrieval_augmentation.md Outdated Show resolved Hide resolved
@qingyun-wu qingyun-wu added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit e1c0423 Mar 14, 2024
23 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* add RAG

* demo

* correct notebook

* Update quarto installation

* Update gitignore

* Update format

* RAG doc

---------

Co-authored-by: Li Jiang <bnujli@gmail.com>
@jackgerrits jackgerrits deleted the more-topics branch September 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants