-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type and default value of the code_execution_config parameter in UserProxyAgent #1996
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1996 +/- ##
===========================================
+ Coverage 37.57% 47.96% +10.39%
===========================================
Files 65 65
Lines 6912 6913 +1
Branches 1521 1648 +127
===========================================
+ Hits 2597 3316 +719
+ Misses 4090 3319 -771
- Partials 225 278 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures need to be fixed before merging.
I'll do it today |
…UserProxyAgent (microsoft#1996) * fix type and default value of the code_execution_config of UserProxAgent * fix type and default value of the code_execution_config of UserProxAgent * set default value of llm_config in UserProxyAgent to None * fixed tests * revert llm_config to False --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Why are these changes needed?
UserProxyAgent
declarescode_execution_config
to be an optional parameter and sets its default value for toNone
autogen/autogen/agentchat/user_proxy_agent.py
Line 33 in 8f6590e
ConversableAgent
deprecated use ofNone
autogen/autogen/agentchat/conversable_agent.py
Line 83 in 8f6590e
Instantiating a user proxy results in a deprecating warning. E.g. by running the following test:
we get the following warning
This PR changes the type and the default value as follows:
autogen/autogen/agentchat/user_proxy_agent.py
Line 33 in a4377d8
This resolves warnings and it behaves identically as before the change.
Related issue number
Closes #1995
Checks