Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [autogenbench] writing to stdout encoding error in win-os #2002

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

lalo
Copy link
Member

@lalo lalo commented Mar 13, 2024

Missed this part of the change in this other PR #1957

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.57%. Comparing base (24418bd) to head (96916db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2002   +/-   ##
=======================================
  Coverage   37.57%   37.57%           
=======================================
  Files          65       65           
  Lines        6912     6912           
  Branches     1521     1521           
=======================================
  Hits         2597     2597           
  Misses       4090     4090           
  Partials      225      225           
Flag Coverage Δ
unittests 37.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi requested a review from afourney March 13, 2024 20:24
@afourney
Copy link
Member

Thanks for fixing this, and the prior PR! LGTM

@sonichi sonichi added this pull request to the merge queue Mar 14, 2024
Merged via the queue into microsoft:main with commit 6dbae0a Mar 14, 2024
26 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants