Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: fix agent_logging test #2036

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Conversation

cheng-tan
Copy link
Contributor

Why are these changes needed?

agent_logging test checks the response from the LLM, which might fail in the CI for some configs due to too many requests. This fix checks the error is logged for failed request or the correct chat completion response is logged for successful request.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (8844f86) to head (9329e81).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
- Coverage   36.99%   36.90%   -0.09%     
==========================================
  Files          66       66              
  Lines        7015     7031      +16     
  Branches     1534     1538       +4     
==========================================
  Hits         2595     2595              
- Misses       4194     4210      +16     
  Partials      226      226              
Flag Coverage Δ
unittests 36.90% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 16, 2024

Can you move this PR to a branch from upstream branch so the open ai tests can run?

@sonichi
Copy link
Contributor

sonichi commented Mar 16, 2024

To run the openai test, please make the PR from the upstream repo.

@sonichi sonichi enabled auto-merge March 17, 2024 01:14
@sonichi sonichi added this pull request to the merge queue Mar 17, 2024
Merged via the queue into microsoft:main with commit 00972a6 Mar 17, 2024
20 of 24 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix test

* Update test/agentchat/test_agent_logging.py

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants