-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix: fix agent_logging test #2036
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2036 +/- ##
==========================================
- Coverage 36.99% 36.90% -0.09%
==========================================
Files 66 66
Lines 7015 7031 +16
Branches 1534 1538 +4
==========================================
Hits 2595 2595
- Misses 4194 4210 +16
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you move this PR to a branch from upstream branch so the open ai tests can run? |
To run the openai test, please make the PR from the upstream repo. |
* fix test * Update test/agentchat/test_agent_logging.py --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Why are these changes needed?
agent_logging test checks the response from the LLM, which might fail in the CI for some configs due to too many requests. This fix checks the error is logged for failed request or the correct chat completion response is logged for successful request.
Related issue number
Checks