Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for longer response to make cache test more robust. #2043

Merged
merged 3 commits into from
Mar 17, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Mar 17, 2024

Why are these changes needed?

Avoid cache test failure like this one: https://github.com/microsoft/autogen/actions/runs/8312062884/job/22746520649?pr=2040

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (448736e) to head (603489a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2043   +/-   ##
=======================================
  Coverage   36.90%   36.90%           
=======================================
  Files          66       66           
  Lines        7031     7031           
  Branches     1538     1538           
=======================================
  Hits         2595     2595           
  Misses       4210     4210           
  Partials      226      226           
Flag Coverage Δ
unittests 36.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/oai/test_client.py Outdated Show resolved Hide resolved
@ekzhu ekzhu enabled auto-merge March 17, 2024 22:03
@ekzhu ekzhu added this pull request to the merge queue Mar 17, 2024
Merged via the queue into main with commit 2cefff9 Mar 17, 2024
23 of 27 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…t#2043)

* Request for longer response to make cache test more robust.

* 1000 words --> 100 words
@ekzhu ekzhu deleted the improve-cache-test branch September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants