Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Icons centered on homepage #2089

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Bug Fix: Icons centered on homepage #2089

merged 2 commits into from
Mar 20, 2024

Conversation

veh3546
Copy link
Contributor

@veh3546 veh3546 commented Mar 19, 2024

Why are these changes needed?

Issue "[Bug]: Icons are off center on homepage #2053" was posted 3/18/24

Related issue number

Closes #2053

Checks

@veh3546
Copy link
Contributor Author

veh3546 commented Mar 19, 2024

This is my first contribution so please let me know if I missed something.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have checked locally.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.88%. Comparing base (5c1579d) to head (80e084b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2089   +/-   ##
=======================================
  Coverage   36.88%   36.88%           
=======================================
  Files          68       68           
  Lines        7062     7062           
  Branches     1540     1540           
=======================================
  Hits         2605     2605           
  Misses       4228     4228           
  Partials      229      229           
Flag Coverage Δ
unittests 36.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and welcome!

@ekzhu ekzhu enabled auto-merge March 20, 2024 02:37
@ekzhu ekzhu added this pull request to the merge queue Mar 20, 2024
Merged via the queue into microsoft:main with commit b2be405 Mar 20, 2024
24 checks passed
@veh3546 veh3546 deleted the patch-1 branch April 8, 2024 21:35
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Icons are off center on homepage
4 participants