Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silences Pip Install Messages in Code Executors #2105

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Silences Pip Install Messages in Code Executors #2105

merged 9 commits into from
Mar 21, 2024

Conversation

WaelKarkoub
Copy link
Contributor

Why are these changes needed?

Related issue number

Closes #2075

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 46.79%. Comparing base (fafc29e) to head (efac097).

Files Patch % Lines
autogen/coding/utils.py 78.57% 1 Missing and 2 partials ⚠️
autogen/coding/jupyter/jupyter_code_executor.py 0.00% 2 Missing ⚠️
autogen/coding/docker_commandline_code_executor.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
+ Coverage   36.90%   46.79%   +9.88%     
==========================================
  Files          68       68              
  Lines        7061     7069       +8     
  Branches     1541     1671     +130     
==========================================
+ Hits         2606     3308     +702     
+ Misses       4225     3477     -748     
- Partials      230      284      +54     
Flag Coverage Δ
unittests 46.66% <70.00%> (+9.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unit tests to check for the expected behavior?

  1. input code block contains pip install, package is valid, output is empty
  2. input code block contains pip install, package is invalid, etc. random strings, output contains error.

See the existing unit tests for jupyter code executor for reference.

@ekzhu ekzhu enabled auto-merge March 21, 2024 20:01
@ekzhu ekzhu added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 3318183 Mar 21, 2024
60 of 72 checks passed
@WaelKarkoub WaelKarkoub deleted the pip-too-verbose branch March 22, 2024 22:45
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix

* adds tests

* check if windows

* adds windows shells

* modifies exit code

* fix powershell

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: automatically quiet pip install in code executors
4 participants