-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code writing with a function call notebook created #2121
Code writing with a function call notebook created #2121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
==========================================
- Coverage 38.14% 35.57% -2.57%
==========================================
Files 78 79 +1
Lines 7865 8089 +224
Branches 1683 1727 +44
==========================================
- Hits 3000 2878 -122
- Misses 4615 4967 +352
+ Partials 250 244 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ekzhu code formatting improved. |
@GregorD1A1 thanks also please add the metadata field in the notebook. |
@ekzhu I'm not familiar with concept of metadata. There is some "metadata" field in lines 926-944. Do you meant that or something different? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot the submit this review. See the comment for what I meant about adding metadata field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you also include the new notebook in the PR?
You can see how to make the notebook show up on the website by following instructions here: https://microsoft.github.io/autogen/docs/contributor-guide/documentation#how-to-get-a-notebook-rendered-on-the-website
Oh, it dessapeared. Copied notebook to the directory again and repaired formatting. |
@GregorD1A1 there is still some issue with the notebook. I created a PR to fix it. Please review: #2403 |
* code writing with function call notebook created * code formatting * code formatting * code formatting * Remarks improved * trying to resolve conflicts in Examples.md * trying to solve conflict, improving llm_config * working on conflict in examples * working on conflict in examples * working with examples.md * examples * repairing examples * Examples updated * notebook included * code formatting * code formatting * tool defenition added * code formatting * dot removed * starting code * starting code --------- Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
@ekzhu
Why are these changes needed?
Added notebook that shows an example of using function calls instead of code executor for creating advanced software apps.
Checks