Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code writing with a function call notebook created #2121

Merged
merged 25 commits into from
Apr 16, 2024

Conversation

GregorD1A1
Copy link
Collaborator

@GregorD1A1 GregorD1A1 commented Mar 22, 2024

@ekzhu

Why are these changes needed?

Added notebook that shows an example of using function calls instead of code executor for creating advanced software apps.

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.57%. Comparing base (4a44093) to head (9bc013b).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   38.14%   35.57%   -2.57%     
==========================================
  Files          78       79       +1     
  Lines        7865     8089     +224     
  Branches     1683     1727      +44     
==========================================
- Hits         3000     2878     -122     
- Misses       4615     4967     +352     
+ Partials      250      244       -6     
Flag Coverage Δ
unittests 35.57% <ø> (-2.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GregorD1A1
Copy link
Collaborator Author

@ekzhu code formatting improved.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 23, 2024

@GregorD1A1 thanks also please add the metadata field in the notebook.

@GregorD1A1
Copy link
Collaborator Author

@ekzhu I'm not familiar with concept of metadata. There is some "metadata" field in lines 926-944. Do you meant that or something different?

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the submit this review. See the comment for what I meant about adding metadata field.

@ekzhu ekzhu added the documentation Improvements or additions to documentation label Mar 25, 2024
website/docs/Examples.md Show resolved Hide resolved
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also include the new notebook in the PR?

You can see how to make the notebook show up on the website by following instructions here: https://microsoft.github.io/autogen/docs/contributor-guide/documentation#how-to-get-a-notebook-rendered-on-the-website

@GregorD1A1
Copy link
Collaborator Author

Oh, it dessapeared. Copied notebook to the directory again and repaired formatting.

@ekzhu ekzhu added this pull request to the merge queue Apr 16, 2024
Merged via the queue into microsoft:main with commit 36f1bf5 Apr 16, 2024
24 checks passed
@ekzhu
Copy link
Collaborator

ekzhu commented Apr 17, 2024

@GregorD1A1 there is still some issue with the notebook. I created a PR to fix it. Please review: #2403

jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
* code writing with function call notebook created

* code formatting

* code formatting

* code formatting

* Remarks improved

* trying to resolve conflicts in Examples.md

* trying to solve conflict, improving llm_config

* working on conflict in examples

* working on conflict in examples

* working with examples.md

* examples

* repairing examples

* Examples updated

* notebook included

* code formatting

* code formatting

* tool defenition added

* code formatting

* dot removed

* starting code

* starting code

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants