Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate_init_message for Multimodal Messages #2124

Merged
merged 19 commits into from
Mar 30, 2024
Merged

Conversation

WaelKarkoub
Copy link
Contributor

Why are these changes needed?

Related issue number

Closes #1924

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.78%. Comparing base (061a857) to head (0ce30ad).
Report is 1 commits behind head on main.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 76.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2124       +/-   ##
===========================================
+ Coverage   37.54%   56.78%   +19.23%     
===========================================
  Files          77       77               
  Lines        7711     7719        +8     
  Branches     1655     1793      +138     
===========================================
+ Hits         2895     4383     +1488     
+ Misses       4573     2971     -1602     
- Partials      243      365      +122     
Flag Coverage Δ
unittest 14.21% <12.00%> (?)
unittests 55.75% <76.00%> (+18.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WaelKarkoub WaelKarkoub changed the title Fix gen_init_message for Multimodal Messages Fix generate_init_message for Multimodal Messages Mar 23, 2024
@sonichi sonichi added the multimodal language + vision, speech etc. label Mar 23, 2024
@sonichi sonichi added this pull request to the merge queue Mar 30, 2024
Merged via the queue into main with commit 7a685b5 Mar 30, 2024
67 of 75 checks passed
@WaelKarkoub WaelKarkoub deleted the mm-gen-init-msg branch March 30, 2024 02:24
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* multimodal carryover

* adds mm carryover tests

* more tests + cleanup code

* check content instead

* beibin suggestion

* cleanup

* fix async

* use deepcopy

* handle carryover method

* remove content copy

* sonichi suggestions

---------

Co-authored-by: Beibin Li <BeibinLi@users.noreply.github.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multimodal language + vision, speech etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: generate_init_message fails for multimodal model.
5 participants