2147 - Fix notebook bug to make a copy of configs for each agent

[jtoy]

Fix notebook bug to make a copy of configs for each agent.

Why are these changes needed?

Related issue number

"Closes #2147"

Checks

• I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
• I've added tests (if relevant) corresponding to the changes introduced in this PR.
• I've made sure all auto checks have passed.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.83%. Comparing base (f795265) to head (61883e6).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2176   +/-   ##
=======================================
  Coverage   37.83%   37.83%           
=======================================
  Files          77       77           
  Lines        7766     7766           
  Branches     1663     1663           
=======================================
  Hits         2938     2938           
  Misses       4579     4579           
  Partials      249      249           

Flag	Coverage Δ
unittests	37.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ekzhu]

Thanks for the PR. there are also other notebooks having similar issues. Do you want to handle them in a separate PR? #2139

[jtoy]

Can we do it in another ticket so we can close this one.  I will setup another ticket  to go through the rest of the tutorials, thanks! On Mar 28, 2024, at 11:00 AM, Eric Zhu ***@***.***> wrote: @ekzhu requested changes on this pull request. Thanks for the PR. there are also other notebooks having similar issues. Do you want to handle them in a separate PR? #2139 In notebook/agentchat_groupchat_RAG.ipynb:

@@ -117,27 +117,30 @@

" description=\"Assistant who has extra content retrieval power for solving difficult problems.\",\n", ")\n", "\n", + "coder_llm_config=llm_config.copy()\n", Instead of making a copy which is not obvious from a quick skim of the code, we should create separate llm_cong in the constructor, and have them share the same config_list in a separate cell in the beginning. E.g., AssistantAgent( name = "product manager", llm_config={"config_list": config_list}, ) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[ekzhu]

Can we do it in another ticket so we can close this one.  I will setup another ticket to go through the rest of the tutorials, thanks! 

Yes. That's my suggestion earlier as well. Let's finish this PR quickly and open a different one for the rest of the notebooks.

BTW you can run pre-commit run --all-files locally to fix the code formatting errors.