Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook on web scraping with tool use #2192

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Notebook on web scraping with tool use #2192

merged 8 commits into from
Apr 2, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Mar 28, 2024

Why are these changes needed?

Provide an example to scrap web pages.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.94%. Comparing base (d970449) to head (fbeec46).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   37.94%   37.94%           
=======================================
  Files          77       77           
  Lines        7780     7780           
  Branches     1666     1666           
=======================================
  Hits         2952     2952           
  Misses       4579     4579           
  Partials      249      249           
Flag Coverage Δ
unittests 37.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu requested a review from jtrugman March 28, 2024 21:24
@ekzhu
Copy link
Collaborator Author

ekzhu commented Mar 29, 2024

@areibman let me know if you want to make improvement over this.

Copy link
Contributor

@areibman areibman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to render this notebook on the website?

@sonichi sonichi requested a review from jackgerrits April 1, 2024 13:51
@jackgerrits
Copy link
Member

jackgerrits commented Apr 1, 2024

Would you like to render this notebook on the website?

I think we should

EDIT: It already is

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the front matter the tags use spaces instead of -. Also scrapping -> scraping

@ekzhu ekzhu enabled auto-merge April 1, 2024 16:12
@ekzhu ekzhu added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit c63c52a Apr 2, 2024
27 checks passed
@ekzhu ekzhu deleted the ekzhu-web-scraping branch April 2, 2024 14:49
thinkall pushed a commit that referenced this pull request Apr 2, 2024
* Add web scrapping notebook

* formatting

* tags

* Update

* update
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add web scrapping notebook

* formatting

* tags

* Update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants