-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support string based UDFs #2195
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
===========================================
+ Coverage 37.97% 49.70% +11.73%
===========================================
Files 75 77 +2
Lines 7587 7757 +170
Branches 1634 1798 +164
===========================================
+ Hits 2881 3856 +975
+ Misses 4463 3582 -881
- Partials 243 319 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
checking it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked for me! Let's get this merged soon!
Small comment: currently all function modules get stored in work_dir. It would be useful if I could provide a custom path within work_dir to use. The reason is that UDFs create a file per function so the number of files in work_dir increases rapidly. In an end app could be displaying files from work_dir to users; |
It should only be a single file for all functions - could you provide more details about when you saw multiple? |
Why are these changes needed?
Related issue number
Checks