-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace iostream warning message with info #2207
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
===========================================
+ Coverage 37.53% 56.72% +19.18%
===========================================
Files 77 77
Lines 7710 7711 +1
Branches 1655 1791 +136
===========================================
+ Hits 2894 4374 +1480
+ Misses 4573 2973 -1600
- Partials 243 364 +121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed on Discord
How to set default to IOConsole? - So I dont get the constant IOstream warnings? Or can you please point me to documentation? No default IOStream has been set, defaulting to IOConsole. Thank you for your kind words! I'm here to assist you whenever you need it. Feel free to reach out if you have any more questions. Have a fantastic day! |
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Why are these changes needed?
IOStream.get_default
function logs a warning when the default is not set for the thread/coroutine. This is changed to an info message as there is no danger of anything breaking.Related issue number
Mentioned in #2204
Checks