Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iostream warning message with info #2207

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Replace iostream warning message with info #2207

merged 2 commits into from
Mar 30, 2024

Conversation

davorrunje
Copy link
Collaborator

Why are these changes needed?

IOStream.get_default function logs a warning when the default is not set for the thread/coroutine. This is changed to an info message as there is no danger of anything breaking.

Related issue number

Mentioned in #2204

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (16db0b9) to head (c6808a5).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2207       +/-   ##
===========================================
+ Coverage   37.53%   56.72%   +19.18%     
===========================================
  Files          77       77               
  Lines        7710     7711        +1     
  Branches     1655     1791      +136     
===========================================
+ Hits         2894     4374     +1480     
+ Misses       4573     2973     -1600     
- Partials      243      364      +121     
Flag Coverage Δ
unittest 14.20% <0.00%> (?)
unittests 55.69% <100.00%> (+18.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi requested review from ekzhu and afourney March 29, 2024 14:28
Copy link
Member

@afourney afourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on Discord

@ekzhu ekzhu added this pull request to the merge queue Mar 30, 2024
Merged via the queue into main with commit 20893fc Mar 30, 2024
67 of 75 checks passed
@jansteh
Copy link

jansteh commented Mar 31, 2024

How to set default to IOConsole? - So I dont get the constant IOstream warnings?
("No default IOStream has been set, defaulting to IOConsole.")

Or can you please point me to documentation?

No default IOStream has been set, defaulting to IOConsole.
No default IOStream has been set, defaulting to IOConsole.
No default IOStream has been set, defaulting to IOConsole.
←[33massistant←[0m (to user_proxy):

Thank you for your kind words! I'm here to assist you whenever you need it. Feel free to reach out if you have any more questions. Have a fantastic day!

whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
@jackgerrits jackgerrits deleted the fix-iostream-warning branch September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants