Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom name for functions module #2241

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

This allows the module name to be overridden. For example, AutoGen Studio will probably use skills

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 28.69%. Comparing base (6ca4785) to head (f7c5661).

Files Patch % Lines
autogen/coding/local_commandline_code_executor.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   37.94%   28.69%   -9.25%     
==========================================
  Files          77       77              
  Lines        7780     7784       +4     
  Branches     1666     1805     +139     
==========================================
- Hits         2952     2234     -718     
- Misses       4579     5291     +712     
- Partials      249      259      +10     
Flag Coverage Δ
unittest 14.36% <28.57%> (?)
unittests 27.63% <28.57%> (-10.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is very useful!

@ekzhu ekzhu added this pull request to the merge queue Apr 2, 2024
Merged via the queue into microsoft:main with commit c3193f8 Apr 2, 2024
58 of 72 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Allow custom name for functions module

* update tests

* reorder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants