Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up contributor guide for better navigability #2250

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Apr 2, 2024

Break up /docs/Contribute into separate pages in a new category /docs/contributor-guide for better navigability, and surfacing important notes such as how to render notebooks.

@ekzhu ekzhu requested a review from jackgerrits April 2, 2024 06:11
@ekzhu ekzhu added the documentation Improvements or additions to documentation label Apr 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.94%. Comparing base (d970449) to head (38f366c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2250   +/-   ##
=======================================
  Coverage   37.94%   37.94%           
=======================================
  Files          77       77           
  Lines        7780     7780           
  Branches     1666     1666           
=======================================
  Hits         2952     2952           
  Misses       4579     4579           
  Partials      249      249           
Flag Coverage Δ
unittests 37.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Josephrp Josephrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@ekzhu ekzhu added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit c27eb0d Apr 2, 2024
27 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@ekzhu ekzhu deleted the ekzhu-website-contributor-guide branch September 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants