Update listdir() in sample code docs to take correct args #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executing this code (Python 3.11, MacOS) returns error `TypeError: listdir: path should be string, bytes, os.PathLike, integer or None, not TemporaryDirectory` Using the string name of the dir works better.
ekzhu
approved these changes
Apr 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
=======================================
Coverage 37.94% 37.94%
=======================================
Files 77 77
Lines 7784 7784
Branches 1667 1667
=======================================
Hits 2954 2954
Misses 4580 4580
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
Executing this code (Python 3.11, MacOS) returns error `TypeError: listdir: path should be string, bytes, os.PathLike, integer or None, not TemporaryDirectory` Using the string name of the dir works better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing this code (Python 3.11, MacOS) returns error
TypeError: listdir: path should be string, bytes, os.PathLike, integer or None, not TemporaryDirectoryUsing the string name of the dir works better.Why are these changes needed?
The code sample in the tutorial doesn't run successfully
Related issue number
Checks