Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort #2265

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Add isort #2265

merged 8 commits into from
Apr 5, 2024

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Apr 3, 2024

Why are these changes needed?

To better organize imports

Added one line to pyproject.toml:
image

And we can have better organized imports
image

Also fixed a circular import error:
280a2c8

Related issue number

Checks

@thinkall thinkall removed the request for review from jackgerrits April 3, 2024 09:04
@thinkall thinkall requested a review from sonichi April 3, 2024 09:04
@thinkall thinkall added the dev development experience/productivity label Apr 3, 2024
@davorrunje
Copy link
Collaborator

@sonichi This should be merged before any other PR because we'll almost certainly get merge conflicts otherwise.

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of getting this merged and fixed ASAP. Thanks!

@sonichi sonichi added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 42b27b9 Apr 5, 2024
66 of 75 checks passed
@sonichi sonichi deleted the add_isort branch April 5, 2024 02:33
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add isort

* Apply isort on py files

* Fix circular import

* Fix format for notebooks

* Fix format

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev development experience/productivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants