Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LMM test in CI by installing lfs #2282

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Apr 4, 2024

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.87%. Comparing base (46bee1f) to head (60e84e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2282       +/-   ##
===========================================
+ Coverage   38.17%   49.87%   +11.69%     
===========================================
  Files          78       78               
  Lines        7812     7812               
  Branches     1669     1807      +138     
===========================================
+ Hits         2982     3896      +914     
+ Misses       4581     3590      -991     
- Partials      249      326       +77     
Flag Coverage Δ
unittest 14.32% <ø> (?)
unittests 48.84% <ø> (+10.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It is so weird that sometimes these tests will but sometimes success.

Thanks for fixing it!~

@sonichi sonichi added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit d4aa27a Apr 5, 2024
57 checks passed
@sonichi sonichi deleted the ekzhu-fix-lmm-tests-ci branch April 5, 2024 02:46
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants