Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types in tool tests #2285

Merged
merged 6 commits into from
Apr 5, 2024
Merged

Fix types in tool tests #2285

merged 6 commits into from
Apr 5, 2024

Conversation

davorrunje
Copy link
Collaborator

Why are these changes needed?

Fixes types in tests of tools related tests.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.98%. Comparing base (16b1db3) to head (cd760f5).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2285       +/-   ##
===========================================
+ Coverage   38.16%   49.98%   +11.81%     
===========================================
  Files          78       78               
  Lines        7861     7861               
  Branches     1681     1819      +138     
===========================================
+ Hits         3000     3929      +929     
+ Misses       4611     3600     -1011     
- Partials      250      332       +82     
Flag Coverage Δ
unittest 14.22% <100.00%> (?)
unittests 48.96% <100.00%> (+10.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 0c0f953 Apr 5, 2024
63 of 75 checks passed
@ekzhu ekzhu deleted the fix-types-tools branch April 5, 2024 15:59
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fixed types related to function calling

* polishing

* fixed types in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants