-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] browser should support custom base url for bing search #2321
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
==========================================
- Coverage 38.14% 36.55% -1.59%
==========================================
Files 78 76 -2
Lines 7865 7859 -6
Branches 1683 1684 +1
==========================================
- Hits 3000 2873 -127
- Misses 4615 4742 +127
+ Partials 250 244 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jackgerrits is this PR ready to merge? |
…oft#2321) * feat: browser is now support custom base url * fix: replae the base url position. * Update bing_base_url parameter in SimpleTextBrowser class
Why are these changes needed?
The browser utils which is called by
WebSurferAgent
should support custombase_url
This
base_url
has been named asbing_base_url
since I wanna remain the same format/naming rule withbing_api_key
.This change has been tested using my own url;
bing_base_url
is optional field.A simple pre-view of how to use is:
Related issue number
#2320
Checks