Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back to top and year #2324

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Add back to top and year #2324

merged 2 commits into from
Apr 9, 2024

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Apr 8, 2024

Why are these changes needed?

  • Add year to the event date as the events are not in the same year
  • Add back to top to the end of each section as the readme is very long

Related issue number

Checks

Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One question: why do we need so many "back to top" button? I think 1 or 2 buttons are good enough. People can always press the "HOME" key to get to the top (unless they are using cellphone, etc.)

@sonichi sonichi added the documentation Improvements or additions to documentation label Apr 9, 2024
Copy link
Collaborator

@manish7017 manish7017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a Table of Contents could help with navigation.

@qingyun-wu qingyun-wu added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit bb374c8 Apr 9, 2024
27 checks passed
@qingyun-wu qingyun-wu deleted the add_back_to_top_and_year branch April 9, 2024 16:33
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add back_to_top and year to readme

* Put in right
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants