Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Handle Missing Contents in Messages in MessageTokenLimiter #2364

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

WaelKarkoub
Copy link
Contributor

Why are these changes needed?

Fixes a bug for cases when contents are missing from a message. Added two tests:

  1. Tests the behavior of the transform when the content type is unexpected.
  2. Check if the transform always returns a message

Related issue number

Closes #2340

Checks

Copy link
Collaborator

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice catch

@WaelKarkoub WaelKarkoub changed the title [Fix] Handle Missing Contents in MessageTokenLimiter [Fix] Handle Missing Contents in Messages in MessageTokenLimiter Apr 11, 2024
@qingyun-wu qingyun-wu added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 78cb908 Apr 12, 2024
71 of 75 checks passed
@qingyun-wu qingyun-wu deleted the handle-none-contents branch April 12, 2024 05:16
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MessageTokenLimiter can't handle missing contents
3 participants