-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add promptflow example #2369
add promptflow example #2369
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2369 +/- ##
==========================================
- Coverage 38.14% 37.02% -1.12%
==========================================
Files 78 81 +3
Lines 7865 8084 +219
Branches 1683 1724 +41
==========================================
- Hits 3000 2993 -7
- Misses 4615 4840 +225
- Partials 250 251 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A few things:
- Can you add some illustrations of what is PromptFlow and how this application integrates PromptFlow with AutoGen. Right now the README dives directly into "Chat flow" but many users do not know what this means.
- Can you add a blurb to the Ecosystem page for PromptFlow? You can find existing examples in
website/docs/ecosystem
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Would benefit from an explanation of the usage and role of Redis as well as alternatives to capture intermediate msgs during agent interactions.
Thank you @ekzhu for your review, i have updated Readme. Can you please take a look again? |
@ekzhu the PR is blocked by your change request. |
@lordlinus are you available on Autogen's discord? I would like to understand your code better by hopping on a call if possible. I'm facing some errors executing your code on my side. Maybe it's just some environment variables not being set or something trivial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error handling and Optional fields if any in YAML and JSON Schema
my Discord id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great start to see more of these shared :
- promptflow is great
- semantic kernel is great
- kernel memory is great
the documentation is 👌🏻very well done
Head branch was pushed to by a user without write access
@lordlinus I see a nice to have feature which can be developed for easy installation and setup of Promptflow.
This can be replicated to other integrations mentioned in as well #140 But we can take this up later too, I'm just suggesting. |
* add promptflow example * add promptflow example * add newline and sort imports * add newline and sort imports * sort imports * fix format errors * update readme * add ecosystem docs * update broken link * update broken link * removing link to samples folder * update readme
Why are these changes needed?
This pull request introduces an example of how to incorporate Autogen within a workflow using PromptFlow. PromptFlow enables the creation, debugging, sharing, and iteration of executable flows, which can then be deployed as API endpoints. Additionally, it provides capabilities for evaluating and monitoring the flow to meet the requirements of enterprise environments.
Related issue number
Checks