Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test speed #2406

Merged
merged 7 commits into from
Apr 17, 2024
Merged

improve test speed #2406

merged 7 commits into from
Apr 17, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Apr 17, 2024

Why are these changes needed?

accelerate openai CI.
addressing the 10 slowest in https://github.com/microsoft/autogen/actions/runs/8714899367/job/23905894422?pr=2313
reducing from 82m to 11m.

Related issue number

Checks

@Hk669
Copy link
Contributor

Hk669 commented Apr 17, 2024

OpenAI / test (ubuntu-latest, 3.9) (pull_request) Successful in 61m

how much faster are the tests now, given that the latest run completed successfully in 61 minutes? @sonichi

@sonichi
Copy link
Contributor Author

sonichi commented Apr 17, 2024

OpenAI / test (ubuntu-latest, 3.9) (pull_request) Successful in 61m

how much faster are the tests now, given that the latest run completed successfully in 61 minutes? @sonichi

reducing from 1h20m to ~10m.

Copy link
Contributor

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks efficient, the changes do increase the test speed, as it is minimizing the iterations of the chat, keeping the config minimal with only gpt-3.5-turbo

@Hk669
Copy link
Contributor

Hk669 commented Apr 17, 2024

OpenAI / test (ubuntu-latest, 3.9) (pull_request) Successful in 61m

how much faster are the tests now, given that the latest run completed successfully in 61 minutes? @sonichi

reducing from 1h20m to ~10m.

that's really a great optimization.

@sonichi sonichi disabled auto-merge April 17, 2024 20:10
@sonichi sonichi added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit d307818 Apr 17, 2024
27 of 31 checks passed
@sonichi sonichi deleted the test416 branch April 17, 2024 20:18
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
* improve test speed

* speed up test

* speed up test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants