Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversable agent: actually print the response in the warning #2438

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

olgavrou
Copy link
Member

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 16.82%. Comparing base (4a44093) to head (e6d3f68).
Report is 43 commits behind head on main.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2438       +/-   ##
===========================================
- Coverage   38.14%   16.82%   -21.32%     
===========================================
  Files          78       82        +4     
  Lines        7865     8337      +472     
  Branches     1683     1743       +60     
===========================================
- Hits         3000     1403     -1597     
- Misses       4615     6887     +2272     
+ Partials      250       47      -203     
Flag Coverage Δ
unittests 16.82% <0.00%> (-21.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@sonichi sonichi added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit d5e30e0 Apr 18, 2024
77 of 90 checks passed
@sonichi sonichi deleted the olgavrou-patch-1 branch April 18, 2024 18:44
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants