Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2447 fix pgvector tests and notebook #2455

Merged
merged 85 commits into from
Apr 28, 2024
Merged

Conversation

Knucklessg1
Copy link
Contributor

@Knucklessg1 Knucklessg1 commented Apr 19, 2024

Why are these changes needed?

  • Notebook was updated with missing details.
  • Corrected pytests
  • Added client error handling
  • Fixed missing username and password parameters
  • Fixed URL encoding of connection string to support symbols in password and username
  • Fixed adding documents logic
  • Added the ability to choose the sentence transformer model.
  • Fixed pre-commits - Bumped openai minimum version to 1.23.3 to support OpenAI vector_store

Related issue number

Closes #2447

Checks

@sonichi sonichi enabled auto-merge April 28, 2024 13:24
@sonichi
Copy link
Contributor

sonichi commented Apr 28, 2024

@LittleLittleCloud I saw that Dotnet Build is required before merging and blocks the PR. This PR shouldn't require that. I'm going to remove it from the required action for now. We can discuss later.

@sonichi sonichi disabled auto-merge April 28, 2024 13:31
@sonichi sonichi enabled auto-merge April 28, 2024 13:31
@sonichi sonichi added this pull request to the merge queue Apr 28, 2024
Merged via the queue into main with commit 1b8d65d Apr 28, 2024
72 of 85 checks passed
@sonichi sonichi deleted the 2447-fix-pgvector-tests-and-notebook branch April 28, 2024 13:50
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
* Re-added missing notebook

* Test installing postgres

* Error handle the connection.

* Fixed import.

* Fixed import.

* Fixed creation of collection without client.

* PGVector portion working. OpenAI untested.

* Fixed prints.

* Added output.

* Fixed pre-commits.

* Run pgvector notebook

* Improve efficiency of get_collection

* Fix delete_collection

* Fixed issues with pytests and validated functions.

* Validated pytests.

* Fixed pre-commits

* Separated extra_requires to allow more logic. Retrieve_chat base dependencies included on pgvector and qdrant.

* Fixed extra newline.

* Added username and password fields.

* URL Encode the connection string parameters to support symbols like %

* Fixed pre-commits.

* Added pgvector service

* pgvector doesn't have health intervals.

* Switched to colon based key values.

* Run on Ubuntu only. Linux is only option with container service support.

* Using default credentials instead.

* Fix postgres setup

* Fix postgres setup

* Don't skip tests on win and mac

* Fix command error

* Try apt install postgresql

* Assert table does not exist when deleted.

* Raise value error on a empty list or None value provided for IDs

* pre-commit

* Add install pgvector

* Add install pgvector

* Reorg test files, create a separate job for test pgvector

* Fix format

* Fix env format

* Simplify job name, enable test_retrieve_config

* Fix test_retrieve_config

* Corrected behavior for get_docs_by_ids with no ids returning all docs.

* Corrected behavior for get_docs_by_ids with no ids returning all docs.

* Fixed pre-commits.

* Added return values for all functions.

* Validated distance search is implemented correctly.

* Validated all pytests

* Removed print.

* Added default clause.

* Make ids optional

* Fix test, make it more robust

* Bump version of openai for the vector_store support

* Added support for choosing the sentence transformer model.

* Added error handling for model name entered.

* Updated model info.

* Added model_name db_config param.

* pre-commit fixes and last link fix.

* Use secrets password.

* fix: link fixed

* updated tests

* Updated config_list.

* pre-commit fix.

* Added chat_result to all output.
Unable to re-run notebooks.

* Pre-commit fix detected this requirement.

* Fix python 3.8 and 3.9 not supported for macos

* Fix python 3.8 and 3.9 not supported for macos

* Fix format

* Reran notebook with MetaLlama3Instruct7BQ4_k_M

* added gpt model.

* Reran notebook

---------

Co-authored-by: Li Jiang <bnujli@gmail.com>
Co-authored-by: Hk669 <hrushi669@gmail.com>
@thinkall thinkall mentioned this pull request Jun 15, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rag retrieve-augmented generative agents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pgvector tests and notebook
8 participants