-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HTML, CSS and Javascript in LocalCommandLineCodeExecutor with Mapping executor/saver #2303 #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asandez1
requested review from
gregnwosu,
ekzhu,
jackgerrits,
AaronWard and
GregorD1A1
April 21, 2024 01:38
3 tasks
@microsoft-github-policy-service agree |
ekzhu
approved these changes
Apr 23, 2024
This was referenced Apr 26, 2024
jayralencar
pushed a commit
to jayralencar/autogen
that referenced
this pull request
May 28, 2024
…utor with Mapping executor/saver microsoft#2303 (microsoft#2464) * Add support for HTML, CSS and Javascript in LocalCommandLineCodeExecutor * init branch * init branch * feat: test code execution added * fix: test update * fix: test * fix: policy test * feat: default policy --------- Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Many web application development use cases require support for simply saving the static content like HTML, CSS and Javascript.
This PR adds support for those languages in LocalCommandLineCodeExecutor.
It also add option in LocalCommandLineCodeExecutor for only saving the code files not executing them. This is useful when the web application code starts a server and never exits.
-EXECUTION_POLICIES mapping of language to whether it should be executed or just saved
Related issue number
Closes #2379 #2383
Checks