Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autogen.AssistantAgent at https://microsoft.github.io/autogen/blog/2023/10/18/RetrieveChat/ #2504

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Hk669
Copy link
Contributor

@Hk669 Hk669 commented Apr 25, 2024

Why are these changes needed?

this could raise an import error for the developer following the tutorial.

Related issue number

Checks

@Hk669 Hk669 requested review from thinkall and sonichi April 25, 2024 05:08
@Hk669 Hk669 added the documentation Improvements or additions to documentation label Apr 25, 2024
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @Hk669 .

@sonichi
Copy link
Contributor

sonichi commented Apr 25, 2024

Given this failure: https://github.com/microsoft/autogen/actions/runs/8827299528/job/24234359966?pr=2504
Let's remove py3.8 from CI.

@Hk669
Copy link
Contributor Author

Hk669 commented Apr 25, 2024

i think we need to address both 3.8, 3.9 @sonichi

Khangduy-live
Khangduy-live approved these changes Apr 25, 2024
@ekzhu ekzhu added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 0d29cfb Apr 25, 2024
49 of 51 checks passed
@ekzhu ekzhu deleted the fix670 branch April 25, 2024 21:30
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants