Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indentation fix to allow assistant agent skills to be generated. reso… #2574

Closed

Conversation

ma-armenta
Copy link

…lves #2506, resolves #2318, resolves #2029

@victordibia @ekzhu

Why are these changes needed?

Function get_skills_from_prompt was not being reach by assistant type agents, since this logic was nested by if agent_spec.config.code_execution_config is not False: which will never be true for assistants and only for user proxy agents.

While investigating, looks like this was introduced on v0.2.20

Related issue number

resolves #2506, resolves #2318, resolves #2029

Checks

@ma-armenta
Copy link
Author

@microsoft-github-policy-service agree

@victordibia
Copy link
Collaborator

victordibia commented May 2, 2024

Hi @ma-armenta ,

Looking good.
Any chance if this issue is resolved in the ORM branch here , workflowmanager

That branch will be merged soon with some significant updates.

-V

@sonichi sonichi requested a review from victordibia May 2, 2024 21:55
@ma-armenta
Copy link
Author

Hi @ma-armenta ,

Looking good. Any chance if this issue is resolved in the ORM branch here , workflowmanager

That branch will be merged soon with some significant updates.

-V

Yeap! thanks!!

@ma-armenta ma-armenta closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants