New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.Net]: Introduce ChatCompletionAgent to AutoGen.SemanticKernel package #2584

Merged

LittleLittleCloud merged 16 commits into microsoft:main from DavidLuong98:u/davidluong98/2481

May 9, 2024

Member

DavidLuong98 commented May 3, 2024

Why are these changes needed?

Now that Semantic Kenrel creates a ChatCompletionAgent in its experimental agent package, it's better to introduce that agent into AutoGen.SemanticKernel package as well so it can be consumed in AutoGen platform

Related issue number

Checks

I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
I've added tests (if relevant) corresponding to the changes introduced in this PR.
I've made sure all auto checks have passed.

luongdavid added 5 commits

May 3, 2024 17:03


          WIP add SKAgent to proj

997be5b


          Fix Unit test

373fe5d


          Remove accidental coommit

4eb8d72


          Add version props

b25f6e0


          Revert Kludge test changes

3ebc244

LittleLittleCloud reviewed

View reviewed changes

dotnet/eng/Version.props Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/AutoGen.SemanticKernel.csproj Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/sample/AutoGen.BasicSamples/Example11_Sequential_GroupChat_Example.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/sample/AutoGen.BasicSamples/CodeSnippet/SemanticKernelCodeSnippet.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/SemanticKernelAgent.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/Extension/KernelExtension.cs Outdated Show resolved Hide resolved

luongdavid added 2 commits

May 6, 2024 21:01


          PR comments : executionSettings and use / upgrade SemanticKernelExper…

5266b16

…imentalVersion


          Add back deleted api and constructor, mark as Obsolete

74871f0

DavidLuong98 requested a review from LittleLittleCloud

May 7, 2024 01:16

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/SemanticKernelAgent.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/SemanticKernelAgent.cs Outdated Show resolved Hide resolved


          PR feedback : Introduce SemanticKernelChatCompletionAgent. Add unit t…

bed5a0b

…ests and refactor semanticKernelChatMessageContentConnector to be SkSequentialChatMessageContentConnector.cs

DavidLuong98 commented

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/Middleware/SemanticKernelChatMessageContentConnector.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/SemanticKernelChatCompletionAgent.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/SemanticKernelChatCompletionAgent.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/src/AutoGen.SemanticKernel/SemanticKernelChatCompletionAgent.cs Outdated Show resolved Hide resolved

LittleLittleCloud reviewed

View reviewed changes

dotnet/test/AutoGen.Tests/SemanticKernelAgentTest.cs Outdated Show resolved Hide resolved

luongdavid added 8 commits

May 8, 2024 19:44


          Revert SkSequentialChatMessageContentConnector

6ac5566


          PR comments, remove systemMessage in SemanticKernelChatCompletionAgent

3b411c2


          Fix formatting

0d9877c


          Merge remote-tracking branch 'origin/main' into u/davidluong98/2481

f846665


          Fix bad merge

a189ad9


          Revert "Fix bad merge"

bd6e4f2

This reverts commit a189ad9.


          Actually merge correctly

55a0cc9


          Remove accidental commit

16fe4b4

LittleLittleCloud approved these changes

View reviewed changes

LittleLittleCloud added this pull request to the merge queue

Merged via the queue into microsoft:main with commit b529fe2

18 checks passed

jayralencar pushed a commit to jayralencar/autogen that referenced this pull request


          [.Net]: Introduce ChatCompletionAgent to AutoGen.SemanticKernel packa…

ba4e341

…ge (microsoft#2584)

* WIP add SKAgent to proj

* Fix Unit test

* Remove accidental coommit

* Add version props

* Revert Kludge test changes

* PR comments : executionSettings and use / upgrade SemanticKernelExperimentalVersion

* Add back deleted api and constructor, mark as Obsolete

* PR feedback : Introduce SemanticKernelChatCompletionAgent. Add unit tests and refactor semanticKernelChatMessageContentConnector to be SkSequentialChatMessageContentConnector.cs

* Revert SkSequentialChatMessageContentConnector

* PR comments, remove systemMessage in SemanticKernelChatCompletionAgent

* Fix formatting

* Fix bad merge

* Revert "Fix bad merge"

This reverts commit a189ad9.

* Remove accidental commit

---------

Co-authored-by: luongdavid <luongdavid@microsoft.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet